Patterns url #130
Merged
Patterns url #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging changes for patternlab 0.8.0
patternlab node 0.8.1 release
Pattern Lab Node 0.9.0
Pulling v0.9.1 into master
|
Hi @scottnath! I checked this out and it looks good - and I think it will even help me with an instance of patternlab I have live that handles this scenario pretty ungracefully. Will be doing some more testing as I can, but I wanted to get this into v0.10.0 THANKS! |
|
Excellent. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bmuenzenmeyer
Rather than change the regex, I tried to create a larger solution that may help with other odd-url situations.
The default is to use Pattern Lab's original behavior when sending the url to the iframe.
Please let me know what changes you'd like.
thanks,
Scott
ps: moved to PR on
devbranch